Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updating Python Requirements #304

Merged
merged 2 commits into from
Jan 24, 2024
Merged

chore: Updating Python Requirements #304

merged 2 commits into from
Jan 24, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Jan 24, 2024 •
edited
Loading

Description

This PR contains package updates with a new temporary constraint to avoid the error raised in this PR by astroid:
#302
https://github.com/openedx/openedx-events/actions/runs/7604751496/job/20708053191#step:6:363

@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner January 24, 2024 15:38
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 24, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi mariajgrimaldi mentioned this pull request Jan 24, 2024
Closed
felipemontoya
felipemontoya approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. @mariajgrimaldi I think you can go ahead and merge as needed

requirements/constraints.txt
@@ -11,3 +11,6 @@

# Latest previous version has issues with doc8 because of conflicting docutils constraints
sphinx-book-theme==0.4.0rc1

# Temporary solution since this version raises RecursionError for test_generate_avro_schemas.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[curious] do we have any plans to every so often go test removing the constrains in this list so as to not make temporary fixes live forever?
Not a blocker by any means.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on waiting for the next astroid release to see if it's solved since the error it's from the package itself. In the meantime, I'll look over the code to figure out why it's failing with only that package. I'll include this removal plan in the in-line comment. Thansk!

@mariajgrimaldi mariajgrimaldi force-pushed the upgrade-python-requirements-1a5f9ca branch from caa9562 to 4e7e273 Compare January 24, 2024 15:54
@mariajgrimaldi mariajgrimaldi force-pushed the upgrade-python-requirements-1a5f9ca branch from 4e7e273 to b78d72d Compare January 24, 2024 16:04
@mariajgrimaldi mariajgrimaldi merged commit bf38cd9 into main Jan 24, 2024
8 checks passed
@mariajgrimaldi mariajgrimaldi deleted the upgrade-python-requirements-1a5f9ca branch January 24, 2024 16:08
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariajgrimaldi @openedx-webhooks @felipemontoya @edx-requirements-bot